Remove container-in-container strategy from CI/CD workflows #223

Closed

Copilot wants to merge 1 commit from copilot/update-workflows-for-ubuntu into main

pull from: copilot/update-workflows-for-ubuntu

merge into: nidde:main

nidde:main

nidde:copilot/full-width-layout-menu-update

nidde:chore/refactor-large-files

nidde:dev

Conversation 1 Commits 1 Files changed 11 +32 -57

Copilot commented

2026-04-16 21:48:40 +00:00

(Migrated from github.com)

Copy link

Description

Self-hosted runner is already a Ubuntu container in Docker — container: blocks on every job caused Docker-in-Docker failures. This removes all container blocks and restores standard GitHub Actions tool setup, so jobs run directly on the host.

Building, testing, and linting remain on the Actions server. Only the pre-built tarball is shipped to the RPi via SCP — no change to the deployment model.

Workflows (6 files): removed container: + GHCR image/credentials block

integrity.yml, build.yml, php-tests.yml, browser-tests.yml, deployment.yml, health-check.yml

Composite actions: restored standard tool installation

setup-php-laravel — re-added shivammathur/setup-php@v2
setup-node-frontend — re-added actions/setup-node@v4 with built-in npm cache, removed manual actions/cache step and unused cache-key-suffix input

build.yml: added apt-get install rsync (was pre-installed in Docker image)

ci-image.yml: removed push trigger, kept workflow_dispatch with deprecation note

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (code change that neither fixes a bug nor adds a feature)
Performance improvement
Test coverage improvement

Testing

I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have tested this manually (if applicable)

Code Quality

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings or errors

CI/CD Checks

All automated tests pass
Code formatting (Pint) passes
JavaScript/TypeScript linting passes
Build process completes successfully

Additional Notes

CI checks on this PR will validate whether the workflows run correctly without containers. The Docker CI image and Dockerfile are retained for reference but no longer actively used.

## Description Self-hosted runner is already a Ubuntu container in Docker — `container:` blocks on every job caused Docker-in-Docker failures. This removes all container blocks and restores standard GitHub Actions tool setup, so jobs run directly on the host. Building, testing, and linting remain on the Actions server. Only the pre-built tarball is shipped to the RPi via SCP — no change to the deployment model. **Workflows** (6 files): removed `container:` + GHCR image/credentials block - `integrity.yml`, `build.yml`, `php-tests.yml`, `browser-tests.yml`, `deployment.yml`, `health-check.yml` **Composite actions**: restored standard tool installation - `setup-php-laravel` — re-added `shivammathur/setup-php@v2` - `setup-node-frontend` — re-added `actions/setup-node@v4` with built-in npm cache, removed manual `actions/cache` step and unused `cache-key-suffix` input **build.yml**: added `apt-get install rsync` (was pre-installed in Docker image) **ci-image.yml**: removed push trigger, kept `workflow_dispatch` with deprecation note ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [x] Refactoring (code change that neither fixes a bug nor adds a feature) - [ ] Performance improvement - [ ] Test coverage improvement ## Testing - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] I have tested this manually (if applicable) ## Code Quality - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings or errors ## CI/CD Checks - [ ] All automated tests pass - [ ] Code formatting (Pint) passes - [ ] JavaScript/TypeScript linting passes - [ ] Build process completes successfully ## Additional Notes CI checks on this PR will validate whether the workflows run correctly without containers. The Docker CI image and Dockerfile are retained for reference but no longer actively used.

coderabbitai[bot] commented

2026-04-16 21:48:54 +00:00

(Migrated from github.com)

Copy link

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 143fc62b-020b-4597-9faa-db273e51391a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!IMPORTANT] > ## Review skipped > > Bot user detected. > > To trigger a single review, invoke the `@coderabbitai review` command. > > <details> > <summary>⚙️ Run configuration</summary> > > **Configuration used**: defaults > > **Review profile**: CHILL > > **Plan**: Free > > **Run ID**: `143fc62b-020b-4597-9faa-db273e51391a` > > </details> > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. > > Use the checkbox below for a quick retry: > - [ ]  🔍 Trigger review   --- <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Reviewers

No reviewers

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

nidde/parenting-tool!223

Reference in a new issue

Repository

nidde/parenting-tool

Title

Body

No description provided.

Delete branch "copilot/update-workflows-for-ubuntu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns